feat: Add startup, readiness, and liveness probes to K8s apps #3211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds startup, readiness, and liveness probes to our Django Kubernetes applications by updating the Pulumi configurations, and it enhances method documentation with descriptive docstrings.
- Adds new probe configurations in the application's initialization and updates for security group and application configurations.
- Introduces clear docstrings for validators and resource initializations to improve code readability.
Ardiea
approved these changes
May 15, 2025
blarghmatey
force-pushed
the
olapp_k8s_probes
branch
2 times, most recently
from
cf06cdf to
2990580
Compare
We currently experience temporary 502s from the applications while they are doing a deployment rollout. This adds startup, readiness, and liveness checks to the pods to ensure that they are ready to serve traffic before they get incorporated into their corresponding service. This depends on upstream changes in the applications in PRS: - mitodl/mit-learn#2247 - mitodl/mitxonline#2652
blarghmatey
force-pushed
the
olapp_k8s_probes
branch
from
2990580 to
6fc2b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
Adds startup, readiness, and liveness probes to our Django K8s apps
Screenshots (if appropriate):
How can this be tested?
Apply it to MITx Online or Learn in CI and verify that the app runs and that the probes are happy.
Additional Context
We currently experience temporary 502s from the applications while they are doing a deployment rollout. This adds startup, readiness, and liveness checks to the pods to ensure that they are ready to serve traffic before they get incorporated into their corresponding service. This depends on upstream changes in the applications in PRS: