feat: retry failed aichat requests #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
added
the
Needs Review
ChristopherChudzicki
changed the title
ChristopherChudzicki
force-pushed
the
cc/retries
branch
from
e79be88 to
70e0731
Compare
jonkafton
reviewed
May 8, 2025
Comment on lines
+103
to
+107
| /** | ||
| * If true, the chat input will be autofocused on load. | ||
| * Defaults to true. | ||
| */ | ||
| autofocus?: boolean |
There was a problem hiding this comment.
This slipped in from our other issue.
jonkafton
reviewed
May 8, 2025
| return false | ||
| } | ||
| if (response) { | ||
| if (response.status < 400) return false |
There was a problem hiding this comment.
Is this just for good measure? I wouldn't expect any status < 400 to produce an error to retry on.
There was a problem hiding this comment.
This is actually necessary: If you implement retryOn as a function, then that is what determines retry, period.
And for fetch:
- promise resolve = network response (possibly an error response, based on status code)
- promise reject = network error
So we really do need to check the status code and explicitly say "Do not retry if < 400".
Alternatively, we could specify retryOn: <array of whitelisted status codes to retry>.
But if we want to retry everything except a specific list, then we need to do it this way.
jonkafton
approved these changes
May 8, 2025
ChristopherChudzicki
added a commit
that referenced
this pull request
May 9, 2025
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/7238
Description (What does it do?)
This PR enables retries on failed AiChat requests. Requests are retried 3 times with exponential backoff, 1s, 2s, 4s.
Screenshots (if appropriate):
How can this be tested?
The easiest way to test this is illustrated in the screenshot above:
yarn startand navigate to http://localhost:6006/?path=/docs/smoot-design-ai-aichat--docs