Skip to content

[VIRTS-4157] track ignored links #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 28, 2022
Merged

[VIRTS-4157] track ignored links #2612

merged 8 commits into from
Jul 28, 2022

Conversation

bleepbop
Copy link
Contributor

Description

Adds data structure to operation object so that it can track ignored links.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit tests for ignorable/non-ignorable links.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop requested review from uruwhy and CDJellen June 23, 2022 14:25
uruwhy
uruwhy previously approved these changes Jun 24, 2022
View reviewed changes
@bleepbop bleepbop requested a review from uruwhy June 24, 2022 16:53
@bleepbop bleepbop mentioned this pull request Jul 20, 2022
Merged
4 tasks
@elegantmoose
Copy link
Contributor

elegantmoose commented Jul 21, 2022 •
edited
Loading

@bleepbop What was the impetus for needing to track ignored links?

@bleepbop
Copy link
Contributor Author

@bleepbop What was the impetus for needing to track ignored links?

@elegantmoose This is part of the Improve Operator Usability epic. Tracking ignored links (and untrusted agents from a previously merged PR) allow us to be more descriptive when providing reasons why an ability did not run. These reasons are provided in the operation report (#2623 addresses these more detailed/accurate reasons).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@elegantmoose elegantmoose merged commit afa3a81 into master Jul 28, 2022
@elegantmoose elegantmoose deleted the bleepbop/VIRTS-4157/track-ignored-links branch July 28, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uruwhy uruwhy uruwhy approved these changes

@CDJellen CDJellen CDJellen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bleepbop @elegantmoose @uruwhy @CDJellen