exporter: export ref name in oci tarball #227
Conversation
client/client_test.go
Outdated
| @@ -280,11 +280,13 @@ func testOCIExporter(t *testing.T, sb integration.Sandbox) { | |||
| defer os.RemoveAll(destDir) | |||
|
|
|||
| out := filepath.Join(destDir, "out.tar") | |||
| target := "docker.io/buildkit/testoci:latest" | |||
There was a problem hiding this comment.
nit: docker.io/buildkit is owned by somebody else: https://hub.docker.com/u/buildkit/
Signed-off-by: Tonis Tiigi <[email protected]>
|
Updated |
| @@ -280,11 +280,13 @@ func testOCIExporter(t *testing.T, sb integration.Sandbox) { | |||
| defer os.RemoveAll(destDir) | |||
|
|
|||
| out := filepath.Join(destDir, "out.tar") | |||
| target := "example.com/buildkit/testoci:latest" | |||
There was a problem hiding this comment.
Sorry for going back and forth, but could you add a testcase for target := "latest", as it seems the most expected value of org.opencontainers.image.ref.name. (example.com/buildkit/testoci:latest is also correct though)
There was a problem hiding this comment.
Is there a place I can read up for this value? I would expect "target=latest" to produce either error or docker.io/library/latest:latest. (the fix for this in #228 produces the latter)
There was a problem hiding this comment.
For OCI, I'd suggest not normalizing the string. i.e. target=latest should set the annotation to latest, literally.
For OCI manifest within Docker-OCI-hybrid image, I'd suggest setting the "tag" portion of the Docker-normalized name.
|
@AkihiroSuda So how about I revert this for now (only leave |
|
Yes, it seems the safest now |
Signed-off-by: Tonis Tiigi [email protected]