-
Notifications
You must be signed in to change notification settings - Fork 120
Do not override std
library during playback
#2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
celinval
merged 4 commits into
model-checking:main
from
celinval:issue-2850-playback-print
Nov 2, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
54db850
Do not override `std` library during playback
celinval 76957eb
Update tests/script-based-pre/playback_print/playback_print.sh
celinval 35478c1
Update tests/script-based-pre/playback_print/print_vars.rs
celinval 823b997
Merge branch 'main' into issue-2850-playback-print
celinval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# Copyright Kani Contributors | ||
# SPDX-License-Identifier: Apache-2.0 OR MIT | ||
script: playback_print.sh | ||
expected: expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
internal error: entered unreachable code: oops | ||
|
||
assertion `left == right` failed: Found 1 != 0 | ||
left: 1 | ||
right: 0 | ||
|
||
assertion `left == right` failed | ||
left: 0 | ||
right: 1 | ||
|
||
Found value 2 | ||
|
||
test result: FAILED. 0 passed; 4 failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
#!/usr/bin/env bash | ||
# Copyright Kani Contributors | ||
# SPDX-License-Identifier: Apache-2.0 OR MIT | ||
|
||
# Test that concrete playback does not override std print functions | ||
|
||
set -o nounset | ||
|
||
function error() { | ||
echo $@ | ||
# Cleanup | ||
rm ${RS_FILE} | ||
rm output.log | ||
exit 1 | ||
} | ||
|
||
RS_FILE="modified.rs" | ||
cp print_vars.rs ${RS_FILE} | ||
export RUSTFLAGS="--edition 2021" | ||
|
||
echo "[TEST] Generate test..." | ||
kani ${RS_FILE} -Z concrete-playback --concrete-playback=inplace | ||
|
||
echo "[TEST] Run test..." | ||
kani playback -Z concrete-playback ${RS_FILE} 2>&1 | tee output.log | ||
|
||
echo "------ Check output ----------" | ||
|
||
set -e | ||
while read -r line; do | ||
grep "${line}" output.log || error "Failed to find: \"${line}\"" | ||
done < expected | ||
|
||
echo | ||
echo "------ Output OK ----------" | ||
echo | ||
|
||
# Cleanup | ||
rm ${RS_FILE} | ||
rm output.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright Kani Contributors | ||
// SPDX-License-Identifier: Apache-2.0 OR MIT | ||
// | ||
// Harness used to test that playback do not override assertion and panic functions. | ||
|
||
#[kani::proof] | ||
pub fn harness() { | ||
let v1: u32 = kani::any(); | ||
let v2: u32 = kani::any(); | ||
// avoid direct assignments to v1 to block constant propagation. | ||
kani::assume(v1 == v2); | ||
|
||
match v2 { | ||
0 => assert_eq!(v1, 1), | ||
1 => assert_eq!(v1, 0, "Found {v1} != 0"), | ||
2 => panic!("Found value {v1}"), | ||
_ => unreachable!("oops"), | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.