Skip to content

complete fix for SampleLlmTool discovery #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

NeverMorewd
Copy link
Contributor

fix the sample TestServerWithHosting according to AspNetCoreSseServer and below issues
#80
#79

Motivation and Context

SampleLlmTool can not be found in TestServerWithHosting

How Has This Been Tested?

Run ChatWithTools with command "TestServerWithHosting .exe" ,show two tools besides SampleLlmTool

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@stephentoub
Copy link
Contributor

@NeverMorewd
Copy link
Contributor Author

Thank you, but this was already fixed: https://github.com/modelcontextprotocol/csharp-sdk/blob/a9175f09179d44c55338cd88b92c8d164f0e18f6/samples/AspNetCoreSseServer/Tools/SampleLlmTool.cs Are you still having issues with it?

It was fixed in AspNetCoreSseServer. TestServerWithHosting need a fix as well, and I noticed there's a pr about that McpServerToolAttr sopport instance members. So we could take this feature as a final scenario?

@stephentoub
Copy link
Contributor

It was fixed in AspNetCoreSseServer. TestServerWithHosting need a fix as well

Oh, I see, we have this duplicated. That duplication doesn't seem ideal. @halter73?

@stephentoub stephentoub merged commit 9330774 into modelcontextprotocol:main Mar 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants