Extend progress notification support #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tyler-R-Kendrick
commented
Mar 31, 2025
Tyler-R-Kendrick
commented
- Added implementation of progress notifications for server and client default handlers.
- Corrected request type hierarchy to provide "meta" parameters from base request to support progress.
- Added IProgress type to sampling handler.
|
This is to address the issue I opened: |
|
Thanks, @Tyler-R-Kendrick. Can you please take a look at the latest in main, and in particular the progress changes that were merged in #145? I expect this PR will need to be changed a bit based on that. |
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
src/ModelContextProtocol/Protocol/Types/ProgressNotificationParams.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
stephentoub
reviewed
Mar 31, 2025
|
Thanks for working on this. I'm going to push a few changes to your branch, if that's ok. |
stephentoub
force-pushed
the
progress-tokens
branch
from
bb54fb7 to
e9faef7
Compare
stephentoub
approved these changes
Apr 1, 2025
|
@Tyler-R-Kendrick, can you please hold off on pushing changes? I was about to merge based on what I'd pushed. |
stephentoub
force-pushed
the
progress-tokens
branch
from
8bb6055 to
e9faef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.