Write "event: message" to SSE response #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Apr 2, 2025
stephentoub
reviewed
Apr 2, 2025
src/ModelContextProtocol/Protocol/Transport/SseResponseStreamTransport.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 2, 2025
eiriktsarpalis
approved these changes
Apr 2, 2025
# Conflicts: # src/ModelContextProtocol/Shared/McpSession.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this wastes a few more bytes per message in the SSE response stream, this appears to be the way to send SSE message events that's most compatible with existing MCP clients.
I also took the opportunity to rename McpJsonRpcEndpoint to just McpEndpoint. I wanted to do that in my earlier refactoring PR that split a lot of it out into McpSession, but I was trying to keep that change as small as I could. I don't think it's worth a whole PR just to rename it now though.
Lastly, I removed the unused McpServerConfig.Arguments property. Arguments are now passed in via McpServerConfig.TransportOptions["arguments"] instead.