Changed the name of the ActivitySource and Metric to clarify that the semantic conventions have not been ratified yet. #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… semantic conventions have not been ratified yet.
stephentoub
reviewed
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prepended the name of the ActivitySource and Metric with Experimental.
Motivation and Context
We have a pattern in the .NET SDK to prepend the namespaces for telemetry with "Experimental" when the semantic conventions are not yet finalized, and so what the source emits are subject to change when the standard is finalized.
How Has This Been Tested?
Run the tests from VS test explorer
Breaking Changes
Yes, if they have consumed telemetry in the hours since #183 was merged.
Types of changes
Checklist
Additional context