Use TryAddEnumerable for McpServerOptionsSetup #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Apr 9, 2025
src/ModelContextProtocol/Configuration/McpServerServiceCollectionExtensions.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered adding a test for this, but as of right now, I don't think running McpServerOptionsSetup.Configure more than once has an observable impact since the things it does either no-ops (like McpServerPrimitiveCollection.TryAdd when attempting to re-add tools and prompts) or overwrites what was done by the last call with the exact same thing (like McpServerHandlers.OverwriteWithSetHandlers). Still, there's no reason to run McpServerOptionsSetup multiple times if we don't have to, and this is the conventional pattern we use for adding IConfigureOptions (see AddMvc).
I thought about this because of the discussion in #240.