Skip to content

Add SchemaCreateOptions in McpServerToolCreateOptions/McpServerPromptCreateOptions #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Add SchemaCreateOptions in McpServerToolCreateOptions/McpServerPromptCreateOptions #354

merged 3 commits into from
Apr 25, 2025

Conversation

1357310795
Copy link
Contributor

Motivation and Context

Fix #353

How Has This Been Tested?

Unit test added and passed.

Breaking Changes

No breaking changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

eiriktsarpalis
eiriktsarpalis reviewed Apr 25, 2025
View reviewed changes
@1357310795 1357310795 changed the title Add SchemaCreateOptions in McpServerToolCreateOptions Add SchemaCreateOptions in McpServerToolCreateOptions/McpServerPromptCreateOptions Apr 25, 2025
eiriktsarpalis
eiriktsarpalis approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@eiriktsarpalis eiriktsarpalis merged commit e190844 into modelcontextprotocol:main Apr 25, 2025
7 checks passed
@1357310795 1357310795 deleted the fix-353 branch April 25, 2025 14:23
@1357310795 1357310795 mentioned this pull request Apr 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to pass AIJsonSchemaCreateOptions in AIFunctionMcpServerTool.Create
2 participants
@1357310795 @eiriktsarpalis