Skip to content

SSE does not work on nested routes #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kocsszi opened this issue May 16, 2025 · 3 comments
Open

SSE does not work on nested routes #733

kocsszi opened this issue May 16, 2025 · 3 comments

Comments

@kocsszi
Copy link

kocsszi commented May 16, 2025

Describe the bug
URL parts are being omitted on SSE client session connect.

INFO:mcp.client.sse:Connecting to SSE endpoint: https://url-part1.url-part2.com/route1/route2/sse
INFO:httpx:HTTP Request: GET https://url-part1.url-part2.com/route1/route2/sse "HTTP/1.1 200 OK"
INFO:mcp.client.sse:Received endpoint URL: https://url-part1.url-part2.com/route2/messages/?session_id=a2bd62740b69466c8b27043ccda2513f
INFO:mcp.client.sse:Starting post writer with endpoint URL: https://url-part1.url-part2.com/route2/messages/?session_id=a2bd62740b69466c8b27043ccda2513f

To Reproduce

import asyncio
import logging
from fastmcp import Client
from fastmcp.client.transports import (
    SSETransport
)


sse_url = "https://url-part1.url-part2.com/route1/route2/sse"
async def main():
    # Connect to a server over SSE (common for web-based MCP servers)
    async with Client(SSETransport(url=sse_url)) as client:
        # Send a message to the server
        result = await client.list_tools()
        print(result)


if __name__ == "__main__":
    logging.basicConfig(level=logging.INFO)
    asyncio.run(main())

Expected behavior
route1 is not omitted

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version 1.9.0

Additional context
issue stems from:
.venv/lib/python3.12/site-packages/mcp/client/sse.py line 66

@Col0ring
Copy link

Col0ring commented May 23, 2025

I have met the same problem. This issue has been closed, did you find a solution?

@kocsszi
Copy link
Author

kocsszi commented May 23, 2025

Hello - yes

For SSE - I had to monkey patch mcp.server.sse.SseServerTransport's connect_sse method.

Somewhere in the middle add your route parts into the root_path variable, for me the patch is

root_path = scope.get("root_path", "") # this is in the mcp codebase
if not LOCAL_SESSION and not root_path.startswith(f"/{MAIN_ROUTE}"): # LOCAL_SESSION identifies if it is local dev run or not
  root_path = f"/{MAIN_ROUTE}" + root_path

In theory you can use some middleware as well in the starlette application and update the root_path in the scope there, but I just could not get that working yet properly.

I'll reopen this issue, as hoping for some guidance as well from maintainers, especially since this method just was updated and still does not work for our use-case properly.

@kocsszi kocsszi reopened this May 23, 2025
@Col0ring
Copy link

Hello - yes

For SSE - I had to monkey patch mcp.server.sse.SseServerTransport's connect_sse method.

Somewhere in the middle add your route parts into the root_path variable, for me the patch is

root_path = scope.get("root_path", "") # this is in the mcp codebase
if not LOCAL_SESSION and not root_path.startswith(f"/{MAIN_ROUTE}"): # LOCAL_SESSION identifies if it is local dev run or not
  root_path = f"/{MAIN_ROUTE}" + root_path

In theory you can use some middleware as well in the starlette application and update the root_path in the scope there, but I just could not get that working yet properly.

I'll reopen this issue, as hoping for some guidance as well from maintainers, especially since this method just was updated and still does not work for our use-case properly.

Thanks for your reply, I just found there is already a PR trying to resolve this, and I also found the official approach #540. I think these might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants