Skip to content

Fix SSE client handling of nested path URLs #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
+11 −2
Closed

Fix SSE client handling of nested path URLs #386

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b42b35a
fix(): SSE client handling of nested path URLs
Mar 27, 2025
5a4d420
style: format max-line
Mar 27, 2025
21a775f
fix: imports
Mar 28, 2025
7e1b9d3
Merge branch 'main' into main
danilpavlov Mar 28, 2025
9a58b30
fixing /mcp case prefix on langchain
jonathanglima Apr 7, 2025
ac3acbb
Merge pull request #1 from jonathanglima/main
danilpavlov Apr 8, 2025
8e76e8a
style: Added noqa to avoid max-line of code
Apr 8, 2025
e6d5b00
Fix generate accurate session_uri for nested SSE paths
sebin1213 Apr 9, 2025
1ac7b63
Fix generate accurate session_uri for nested SSE paths
sebin1213 Apr 9, 2025
7cece5e
Fix generate accurate session_uri for nested SSE paths
sebin1213 Apr 9, 2025
96baf33
Merge pull request #2 from sebin1213/main
danilpavlov Apr 9, 2025
3728328
style: format to avoid max-line validation error
Apr 9, 2025
e1ca588
style: reorganize imports
Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: format to avoid max-line validation error
  • Loading branch information
eyeonyou committed Apr 9, 2025
commit 3728328497814e046293e5ffc8ac8571968e9e2d
5 changes: 4 additions & 1 deletion src/mcp/server/sse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,12 @@ async def connect_sse(self, scope: Scope, receive: Receive, send: Send):

session_id = uuid4()
request_path = scope["path"]

match = re.match(r"^/([^/]+(?:/mcp)?)/sse$", request_path)
mount_prefix = match.group(1) if match else ""
session_uri = f"/{quote(mount_prefix)}{quote(self._endpoint)}?session_id={session_id.hex}"

session_uri = f"/{quote(mount_prefix)}{quote(self._endpoint)}"
session_uri += f"?session_id={session_id.hex}"

self._read_stream_writers[session_id] = read_stream_writer
logger.debug(f"Created new session with ID: {session_id}")
Expand Down
Loading