-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix hanging on streams when stdio_client exiting #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
22e2b3a
Fix the TaskGroup hanging on stdin_writer when stdio_client exiting
LionNatsu 2774496
Add test_stdio_cm for stdin_writer hanging
LionNatsu 2591f80
Test using simple tee instead of mcp-server-fetch
LionNatsu 474f072
Close write_stream_reader in finally block
LionNatsu d2f1146
Fix pyright warnings in test_stdio_cm.py
LionNatsu 12d4740
Fix read_stream stream leakage
LionNatsu 15b24eb
Update test_stdio.py
LionNatsu a2e3328
Delete tests/client/test_stdio_cm.py
LionNatsu a59995e
Update src/mcp/client/stdio/__init__.py
LionNatsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import pytest | ||
|
||
from mcp import StdioServerParameters | ||
from mcp.client.stdio import stdio_client | ||
|
||
|
||
@pytest.mark.anyio | ||
async def test_context_manager_exiting(): | ||
async with stdio_client(StdioServerParameters(command="tee")) as ( | ||
LionNatsu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
read_stream, | ||
write_stream, | ||
LionNatsu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
): | ||
pass |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.