Skip to content

fix: 204 is an acceptable response to DELETEing the session #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

nbarbettini
Copy link
Contributor

@nbarbettini nbarbettini commented May 12, 2025

Closes #696

Motivation and Context

204 is the correct response code to return for a body-less response, per RFC 7231.

How Has This Been Tested?

  • New tests

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ihrpr ihrpr merged commit f745d69 into modelcontextprotocol:main May 12, 2025
6 checks passed
@nbarbettini nbarbettini deleted the fix-delete-session-204 branch May 12, 2025 20:25
@nbarbettini
Copy link
Contributor Author

No problem, thanks for the quick merge @ihrpr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting the session logs a warning if the server responds with HTTP 204
2 participants