chore: add telemetry unit tests #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14672206053Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for telemetry functionalities to ensure correct event emission behaviors under various conditions.
- Introduces tests for sending events and caching on failures when telemetry is enabled.
- Adds tests to verify no events are sent when telemetry is disabled or DO_NOT_TRACK is enabled.
- Verifies that common telemetry properties are correctly attached to events.
gagik
approved these changes
Apr 28, 2025
|
|
||
| beforeEach(() => { | ||
| // Reset mocks before each test | ||
| jest.clearAllMocks(); |
There was a problem hiding this comment.
I'm not too familiar with jest but since the original file mock happens in the global scope and doesn't get re-run; doesn't that imply this should clear that as well?
I assume this works I'm just trying to understand if jest doesn't clear file mocks here or something
There was a problem hiding this comment.
yep thanks for the question, the global scope ones guarantee that we won't use the actual implementation while the clear will simply clean up any leftover state between runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.