fix: use record instead of a passthrough object #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
force-pushed
the
gagik/use-unknown-record
branch
from
659208a to
263e35d
Compare
|
Something looks wrong with the checks - not sure why GHA hasn't run the workflow. |
gagik
force-pushed
the
gagik/use-unknown-record
branch
from
263e35d to
f67838e
Compare
gagik
changed the title
gagik
force-pushed
the
gagik/use-unknown-record
branch
from
261a0a0 to
e839c6b
Compare
blva
approved these changes
Apr 28, 2025
gagik
force-pushed
the
gagik/use-unknown-record
branch
from
c073ae7 to
e839c6b
Compare
nirinchev
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139.
Needs additional testing with other editors to ensure a record of unknowns is similarly respected. Tested with Claude.