fix: bad auth error

[fmenezes]

This essentially keeps trying to connect because after user is created it might take some time for it to be available.

note: also making deletion of user async on disconnect to reduce change of timeout

[Copilot]

Pull Request Overview

This pull request addresses authentication issues by implementing a retry mechanism for connecting to the MongoDB cluster and making user deletion asynchronous.

• Introduces a retry loop for connecting to MongoDB in connectCluster.ts.
• Adjusts user deletion in session.ts to run asynchronously to prevent timeouts.
• Adds a new logging identifier in logger.ts to support the retry mechanism.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/tools/atlas/metadata/connectCluster.ts	Adds a retry loop for connecting to MongoDB with logging on failure
src/session.ts	Refactors user deletion to be asynchronous using promise chaining
src/logger.ts	Adds a new logging identifier for connection failures

[Copilot]

If all retry attempts fail, the connection error is silently swallowed. Consider throwing an error or returning a failure state after exhausting all attempts.

Suggested change

	await this.session.connectToMongoDB(connectionString, this.config.connectOptions);
	for (let i = 0; i < 20; i++) {
	try {
	await this.session.connectToMongoDB(connectionString, this.config.connectOptions);
	let connected = false;
	for (let i = 0; i < 20; i++) {
	try {
	await this.session.connectToMongoDB(connectionString, this.config.connectOptions);
	connected = true;

[blva]

nit: can we add tests for this in a follow-up?

[fmenezes]

in the integration tests we can't force a user to take longer to be created, we could try with unit tests, but none of the tools are covered in unit at the moment