feat: add atlas access list tools #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
approved these changes
Apr 9, 2025
| await this.ensureAuthenticated(); | ||
|
|
||
| if (!ipAddresses?.length && !cidrBlocks?.length) { | ||
| throw new Error("Either ipAddresses or cidrBlocks must be provided."); |
There was a problem hiding this comment.
Should we default to the device's public IP address? Alternatively, we can lookup the current IP address and respond with a prompt whether to add it - something like:
return {
content: [{
type: "text",
text: "Either an IP address or a CIDR block must be provided. The current device's public IP address is: a.b.c.d - do you want to use that?"
}]
}There was a problem hiding this comment.
thanks for pointing out, I'll handle current ips on a follow up PR, I'll check if makes sense to have a resource for this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30
atlas-inspect-access-listtoolatlas-create-access-listtool