-
Notifications
You must be signed in to change notification settings - Fork 39
refactor: rename state to session, combine tool registration, and clearer dependencies #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff955c5
to
cbd3e1d
Compare
cbd3e1d
to
3d9f963
Compare
3d9f963
to
6c8752b
Compare
nirinchev
approved these changes
Apr 10, 2025
nirinchev
requested changes
Apr 10, 2025
…gagik/null-assertions
…gagik/strict-eslint
…cp-server into gagik/null-assertions
71a3885
to
8e4f19c
Compare
d43beaa
to
e2e296b
Compare
4de7d50
to
2a87387
Compare
…gagik/null-assertions
fmenezes
reviewed
Apr 11, 2025
fmenezes
reviewed
Apr 11, 2025
tool.register(server); | ||
} | ||
} | ||
export const AtlasTools = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Filipe Constantinov Menezes <[email protected]>
fmenezes
approved these changes
Apr 11, 2025
nirinchev
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just makes it clearer what goes where. I think session was a lot easier for me to reason about than state.
This did end up a bit all over the place because of the different changes in the codebase but hopefully is still reviewable.