Skip to content

refactor: rename state to session, combine tool registration, and clearer dependencies #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 11, 2025

Conversation

gagik
Copy link
Collaborator

@gagik gagik commented Apr 10, 2025

Just makes it clearer what goes where. I think session was a lot easier for me to reason about than state.
This did end up a bit all over the place because of the different changes in the codebase but hopefully is still reviewable.

@gagik gagik force-pushed the gagik/null-assertions branch 3 times, most recently from ff955c5 to cbd3e1d Compare April 10, 2025 17:41
@gagik gagik marked this pull request as draft April 10, 2025 17:44
@gagik gagik force-pushed the gagik/null-assertions branch from cbd3e1d to 3d9f963 Compare April 10, 2025 18:27
@gagik gagik force-pushed the gagik/null-assertions branch from 3d9f963 to 6c8752b Compare April 10, 2025 19:10
@gagik gagik marked this pull request as ready for review April 10, 2025 19:11
@gagik gagik marked this pull request as draft April 11, 2025 12:33
@gagik gagik force-pushed the gagik/null-assertions branch from 71a3885 to 8e4f19c Compare April 11, 2025 13:43
@gagik gagik changed the base branch from main to gagik/strict-eslint April 11, 2025 13:53
@gagik gagik force-pushed the gagik/null-assertions branch from d43beaa to e2e296b Compare April 11, 2025 13:54
Base automatically changed from gagik/strict-eslint to main April 11, 2025 14:08
@gagik gagik force-pushed the gagik/null-assertions branch from 4de7d50 to 2a87387 Compare April 11, 2025 14:10
@gagik gagik changed the title refactor: remove type assertions and simplify state setup refactor: rename state to session, combine tool registration, and clearer dependencies Apr 11, 2025
@gagik gagik marked this pull request as ready for review April 11, 2025 14:20
tool.register(server);
}
}
export const AtlasTools = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Co-authored-by: Filipe Constantinov Menezes <[email protected]>
@gagik gagik changed the base branch from main to chore_add_license_fix_version April 11, 2025 14:51
@gagik gagik changed the base branch from chore_add_license_fix_version to main April 11, 2025 14:51
@gagik gagik merged commit 8ca583a into main Apr 11, 2025
@gagik gagik deleted the gagik/null-assertions branch April 11, 2025 14:54
nirinchev added a commit that referenced this pull request Apr 11, 2025
* main:
  chore: auto generate apiClient (#64)
  refactor: rename state to session, combine tool registration, and clearer dependencies (#55)
  chore: add type-powered eslint rules (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants