feat: change Atlas API auth to service accounts #59
Conversation
README.md
Outdated
| | ------------------ | --------------------------------------------------------------------------- | | ||
| | `apiClientId` | Atlas API client ID for authentication | | ||
| | `apiClientSecret` | Atlas API client secret for authentication | | ||
| | `stateFile` | Path to store application state (default ~/.mongodb/mongodb-mcp/state.json) | |
There was a problem hiding this comment.
We can drop this now - I forgot to remove it as part of #48 😅
README.md
Outdated
| | `apiClientId` | Atlas API client ID for authentication | | ||
| | `apiClientSecret` | Atlas API client secret for authentication | | ||
| | `stateFile` | Path to store application state (default ~/.mongodb/mongodb-mcp/state.json) | | ||
| | `connectionString` | MongoDB connection string for direct database connections | |
There was a problem hiding this comment.
We should probably indicate this is optional and if not provided, the connect tool should be used.
| status: "not_auth" | "requested" | "issued"; | ||
| code?: OauthDeviceCode; | ||
| token?: OAuthToken; | ||
| }; | ||
| connectionString?: string; |
There was a problem hiding this comment.
Per slack discussion, let's drop the connection string storage and rely on users either providing it every time or supplying it as env variable. I know this will turn the credentials field to an empty object, but we could keep it around for persisting sensitive data after we go through security review. It will also allow the security team to review the mechanisms we intend to use for secure storage.
There was a problem hiding this comment.
will do that on a follow up PR
src/tools/atlas/atlasTool.ts
Outdated
|
|
||
| export abstract class AtlasToolBase extends ToolBase { | ||
| constructor( | ||
| state: State, | ||
| protected apiClient: ApiClient | ||
| protected apiClient?: ApiClient | ||
| ) { | ||
| super(state); | ||
| } | ||
|
|
||
| protected async ensureAuthenticated(): Promise<void> { |
There was a problem hiding this comment.
| protected async ensureAuthenticated(): Promise<void> { | |
| protected ensureAuthenticated(): void { |
src/tools/atlas/atlasTool.ts
Outdated
|
|
||
| export abstract class AtlasToolBase extends ToolBase { | ||
| constructor( | ||
| state: State, | ||
| protected apiClient: ApiClient | ||
| protected apiClient?: ApiClient | ||
| ) { | ||
| super(state); | ||
| } | ||
|
|
||
| protected async ensureAuthenticated(): Promise<void> { |
There was a problem hiding this comment.
| protected async ensureAuthenticated(): Promise<void> { | |
| protected ensureAuthenticated(): asserts this is { apiClient: ApiClient } { |
should let you get rid of all ! if you remove the await-s
* main: feat: change Atlas API auth to service accounts (#59)
fixes #39