Skip to content

ci: add eslint #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

ci: add eslint #7

merged 4 commits into from
Apr 8, 2025

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Apr 8, 2025

  • added eslint (via npm run lint)
  • added github action to check eslint
  • changed github action prettier to actually check if code needs reformatting
  • added eslint-config-prettier to make sure eslint does not touch formatting without prettier

@fmenezes fmenezes marked this pull request as ready for review April 8, 2025 11:16
Copy link
Collaborator

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; would be good to follow-up later with aligning eslint and .prettier.json with devtools things in some form

@fmenezes fmenezes merged commit a1f101f into main Apr 8, 2025
3 checks passed
@fmenezes fmenezes deleted the ci_add_eslint branch April 30, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants