Skip to content

DRIVERS-3208 Option to avoid docker login for local testing #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 20, 2025

Tested locally:

$ bash run-server.sh
~/workspace/drivers-evergreen-tools ~/workspace/drivers-evergreen-tools/.evergreen/docker
[+] Building 7.7s (7/10)                                                                           docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 1.04kB                                                                             0.0s
 => [internal] load metadata for docker.io/library/ubuntu:20.04                                                    1.0s
...
$ CI=1 bash run-server.sh
~/workspace/drivers-evergreen-tools/.evergreen/docker ~/workspace/drivers-evergreen-tools/.evergreen/docker
Traceback (most recent call last):
  File "/Users/steve.silvester/workspace/drivers-evergreen-tools/.evergreen/docker/login.py", line 20, in <module>
    ExternalId=os.environ["AWS_EXTERNAL_ID"],
               ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "<frozen os>", line 716, in __getitem__
KeyError: 'AWS_EXTERNAL_ID'

@blink1073 blink1073 requested a review from prestonvasquez June 20, 2025 11:37
Copy link
Contributor

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐳

@blink1073 blink1073 merged commit 147364a into mongodb-labs:master Jun 20, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants