RUST-395 Log skipped tests #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
force-pushed
the
RUST-395/log-skipped-tests
branch
from
9cc0208 to
9229022
Compare
|
I've updated this to log skips in a way that's not captured by |
isabelatkinson
approved these changes
Jan 21, 2022
patrickfreed
reviewed
Feb 2, 2022
src/cmap/test/mod.rs
Outdated
| @@ -431,7 +432,7 @@ async fn cmap_spec_tests() { | |||
|
|
|||
| let mut options = CLIENT_OPTIONS.clone(); | |||
| if options.load_balanced.unwrap_or(false) { | |||
| println!("skipping due to load balanced topology"); | |||
| log_uncaptured("skipping due to load balanced topology"); | |||
There was a problem hiding this comment.
can we add which test is being skipped here?
| @@ -643,7 +644,7 @@ async fn direct_connection() { | |||
|
|
|||
| let test_client = TestClient::new().await; | |||
| if !test_client.is_replica_set() { | |||
| println!("Skipping due to non-replica set topology"); | |||
| log_uncaptured("Skipping due to non-replica set topology"); | |||
There was a problem hiding this comment.
ditto add test name here
src/test/atlas_connectivity.rs
Outdated
| async fn run_test(uri_env_var: &str, resolver_config: Option<ResolverConfig>) { | ||
| if std::env::var_os("MONGO_ATLAS_TESTS").is_none() { | ||
| log_uncaptured("skipping test due to undefined environment variable MONGO_ATLAS_TESTS"); |
src/test/spec/connection_stepdown.rs
Outdated
| @@ -31,6 +31,7 @@ async fn run_test<F: Future>( | |||
| let client = EventClient::with_additional_options(Some(options), None, None, None).await; | |||
|
|
|||
| if !client.is_replica_set() { | |||
| log_uncaptured("skipping test due to not running on a replica set"); | |||
| @@ -173,6 +179,8 @@ async fn run_test(mut test_file: TestFile) { | |||
|
|
|||
| RUNTIME.delay_for(Duration::from_millis(500)).await; | |||
| } | |||
| } else { | |||
| log_uncaptured("skipping test due to test topology"); | |||
There was a problem hiding this comment.
think this needs test name and maybe more details about what is off about the topology
abr-egn
force-pushed
the
RUST-395/log-skipped-tests
branch
from
83a337b to
71eeab7
Compare
patrickfreed
approved these changes
Feb 4, 2022
abr-egn
force-pushed
the
RUST-395/log-skipped-tests
branch
from
011681e to
b54437e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-395
This PR adds logging to test cases that are skipped and enables the
--nocaptureflag to allow the test framework to print output for skipped tests.