RUST-523 Support change streams in unified spec tests #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/spec/json/change-streams/legacy/change-streams-errors.json
Outdated
Show resolved
Hide resolved
| @@ -44,14 +45,21 @@ pub struct ClientEntity { | |||
| observe_sensitive_commands: bool, | |||
| } | |||
|
|
|||
| impl ClientEntity { | |||
There was a problem hiding this comment.
I don't think this method is necessary -- ClientEntity implements Deref with a target type of Client so you should be able to call watch directly on a ClientEntity (where this method is used).
There was a problem hiding this comment.
I missed that, thank you! Removed.
patrickfreed
approved these changes
Jan 27, 2022
isabelatkinson
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-523
This pulls in the unified spec test for change streams and adds support to the Rust unified runner for creating and iterating change streams. I also added more detailed mismatch reporting to the runner as part of debugging initial failures.