refactor(caret): move active word element offset to test-state and remove .smoothScroller (@NadAlaba) #6541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
activeWordElementOffset
totest-state.ts
to allowcaret.ts
to use it without causing circular dependency:caret.ts
because it'd cause circular dependency. This move ofactiveWordElementOffset
totest-state.ts
would solve the issue.Remove unneeded
.smoothScroller
:.smoothScoller
was only needed to transmit information from test-ui.ts to caret.ts in order to help with caret's vertical positioning during line jump. Now it is replaced by a variablelineScrollDistance
intest-state.ts
which gets set intest-ui.ts: lineJump()
and used incaret.ts
.Remove the unnecessary parameter
activeWordEmpty
fromcaret.ts: getTargetPositionLeft()
and cleanup:activeWordEmpty
inupdatePosition()
is not needed either, because in zen mode we setwordLen = inputLen
, soactiveWordEmpty
is exactly the same aswordLen === 0
.Change variable name from
activeWordElementOffset
toremovedUIWordCount
& add a helper function:incrementRemovedUIWordCount()
to shorten code changing the variable's value.