Skip to content

fix(input-controller): prevent default behavior for Arrow keys and ctrl+a in #wordsInput (@raaid3) #6635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

raaid3
Copy link

@raaid3 raaid3 commented Jun 12, 2025

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/contracts/src/schemas/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/contracts/src/schemas/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
    • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/contracts/src/schemas/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #6634

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jun 12, 2025
@raaid3 raaid3 changed the title fix(input-controller): prevent default behavior for Arrow keys and ctrl+a fix(input-controller): prevent default behavior for Arrow keys and ctrl+a in #wordsInput (@raaid3) Jun 12, 2025
@Miodec
Copy link
Member

Miodec commented Jun 16, 2025

image

I found that this works in Firefox on Mac. Can you confirm it works for you too and if it does, update the PR?

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 16, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 16, 2025
@raaid3
Copy link
Author

raaid3 commented Jun 16, 2025

It works for me on windows as well, and I've updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl + a selects all in firefox
3 participants