fix(caret): misalignment issue when switching between carets (@byseif21) #6642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes a caret misalignment issue that occurred when switching between caret styles (e.g., from block/outline/underline to line caret).
Bug:
When switching caret styles, the line caret could retain the width from the previous style (e.g., block), causing it to appear visually incorrect until the next input.
Root Cause:
width
was not reset when changing styles, so the new style inherited the old dimensions.updatePosition()
was called before the style was fully applied, leading to incorrect positioning.Fix
Added a
subscribe
listener incaret.ts
for the"caretStyle"
event.When the caret style changes:
The caret's inline width is reset:
Its position is immediately recalculated with: