feat: Add process state to /upstream #135
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ProxyManager
participant ProcessGroup
participant Process
User->>ProxyManager: Request upstream index
ProxyManager->>ProxyManager: Retrieve and sort model IDs
loop For each model ID
ProxyManager->>ProcessGroup: Find process group for model
ProcessGroup-->>ProxyManager: Return process group (if exists)
ProxyManager->>Process: Find process for model
Process-->>ProxyManager: Return process (if exists)
ProxyManager->>Process: Get current state
Process-->>ProxyManager: Return state (e.g., Ready, Starting)
ProxyManager->>ProxyManager: Map state to human-readable string
ProxyManager->>ProxyManager: Append model link and state to HTML
end
ProxyManager-->>User: Return HTML with model links and states
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
proxy/proxymanager.go (1)
337-361: Good addition of process state information, but consider handling nil casesThe implementation nicely displays process state alongside model names, making it easier for users to understand the current status of each model. The mapping from internal state constants to human-readable strings is well done with a proper default case.
However, when a process group or process doesn't exist for a model ID, the code will display " - " (dash with empty state) in the HTML. Consider initializing the
statevariable with a default value like "Not Running" to provide more clarity in these cases.var state string = "Not Running" // Default state when process doesn't exist if processGroup != nil { process := processGroup.processes[modelID] if process != nil { var stateStr string switch process.CurrentState() {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
proxy/proxymanager.go(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
proxy/proxymanager.go (1)
proxy/process.go (5)
StateReady(23-23)StateStarting(22-22)StateStopping(24-24)StateFailed(27-27)StateShutdown(30-30)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: run-tests
|
thanks! |
This PR adds information about the process for model right after the model name in the HTML page created by /upstream
Summary by CodeRabbit