Remove ignore dependency and use rayon for file scanning for #1333 #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tugtugtug
force-pushed
the
remove-ignore-dep
branch
3 times, most recently
from
9d77862 to
2111bcd
Compare
…1333 While ignore is great for collecting files while applying certain auto filters, it barely provides anything that is used by this tool. All we needed was a way to process the binary file searches in parallel. - Implemented a simple parallel file walker uses Rayon to parallelize the file search. - Added tests to cover the new implementation - Compared the benchmarks with ignore, and the new implementation performs better consistently on my setup (Apple M4 Max). - Verified this fixed the empty outputs for people running grcov with a .gitignore that includes the output folder.
tugtugtug
force-pushed
the
remove-ignore-dep
branch
from
2111bcd to
222cf52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1333
While ignore is great for collecting files while applying certain auto filters, it barely provides anything that is used by this tool. All we needed was a way to process the binary file searches in parallel.