Skip to content

Priority Queue Update (To branch) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Priority Queue Update (To branch) #160

merged 3 commits into from
Oct 7, 2024

Conversation

v-fearam
Copy link
Contributor

@v-fearam v-fearam commented Sep 4, 2024

Priority Queue

  • RG name includes the location name
  • Library Updates
  • Unused Library deleted
  • Changed to primary contractor new feature.
  • Azure function using Managed Identity to access Service Bus
  • Changing to AddAzureClients, and moved to managed identity
  • Adding bicep to create all resources on one shot
  • Create command instruction to update settings
  • Changing readme to use "func start" and update instructions based on the updates

Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @v-fearam !

Per Chad's original feedback, can you remove anything to do with testing locally (We only want the deploy-to-Azure version), and remove the requirement of Visual Studio?

@v-fearam
Copy link
Contributor Author

v-fearam commented Sep 12, 2024

I will remove the Visual Studio Requirement.
However, I have some concern about full azure deploy. The patterns usually deploy resources and run the compute locally, for example:
https://github.com/mspnp/cloud-design-patterns/tree/main/claim-check/code-samples/sample-1
or
https://github.com/mspnp/cloud-design-patterns/tree/main/valet-key
or
https://github.com/mspnp/cloud-design-patterns/tree/main/pipes-and-filters
among others (You will see func start in all of them)

In that way, the priority queue is consistent with them. We can do it, we need to deploy the App Funtion in the bicep and deploy them, but It is going to take time and It will be insconsistent to the rest of the examples.

Let me know your opinion.

@v-fearam
Copy link
Contributor Author

Removed VS requirement

Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve to branch then review again there

@skabou skabou merged commit ea84f2a into mspnp:priority-queue-update Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants