reorder SDL text command help to match parsing #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a very small patch to fix the ordering of the SDL
text
subcommand help, which was not what was being parsed. The string to be drawn is in fact the first argument.In first looking at this, I thought it might make sense to change the parsing to match the help text, but that's more complicated and is unlike any other SDL subcommand in that it features multiple numeric arguments and a string. Due to the way that
JimSdlGetLongs()
is used, having the string argument be in the middle of the numeric arguments makes this a bit more wordy and error-prone. I could certainly submit it that way, but I think an argument is equally able to be made, sincetext
is unique, that the string argument does in fact come first, followed by all the numeric arguments in the same order as several other subcommands.Lastly, this change doesn’t break any existing code which makes use of the extension.