Skip to content

reorder SDL text command help to match parsing #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Feb 5, 2024

Here's a very small patch to fix the ordering of the SDL text subcommand help, which was not what was being parsed. The string to be drawn is in fact the first argument.

In first looking at this, I thought it might make sense to change the parsing to match the help text, but that's more complicated and is unlike any other SDL subcommand in that it features multiple numeric arguments and a string. Due to the way that JimSdlGetLongs() is used, having the string argument be in the middle of the numeric arguments makes this a bit more wordy and error-prone. I could certainly submit it that way, but I think an argument is equally able to be made, since text is unique, that the string argument does in fact come first, followed by all the numeric arguments in the same order as several other subcommands.

Lastly, this change doesn’t break any existing code which makes use of the extension.

@msteveb msteveb merged commit 3672848 into msteveb:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants