fix: use rice when embedding large binaries #5309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudler
force-pushed
the
feat/go-rice
branch
3 times, most recently
from
af46c56 to
c35cebd
Compare
mudler
changed the title
mudler
force-pushed
the
feat/go-rice
branch
5 times, most recently
from
cacad7a to
789c871
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -56,7 +58,7 @@ | |||
| // If there is a lib directory, set LD_LIBRARY_PATH to include it | |||
| // we might use this mechanism to carry over e.g. Nvidia CUDA libraries | |||
| // from the embedded FS to the target directory | |||
| library.LoadExtractedLibs(extractDir) | |||
| library.LoadExtractedLibs(backendAssetsDir) | |||
Check warning
Code scanning / gosec
Errors unhandled Warning
Golang embed FS has a hard limit that we might exceed when providing many binary alternatives. Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
Notes for Reviewers
Signed commits