fix(gpu): do not assume gpu being returned has node and mem #5310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Di Giacinto <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to improve error handling and ensure robustness in VRAM estimation logic. The updates focus on adding checks for nil values and refining conditions to handle edge cases.
Improvements to error handling and robustness:
core/config/gguf.go: Updated theguessGGUFFromFilefunction to only estimate VRAM usage if the available VRAM is greater than zero, preventing unnecessary operations when VRAM is unavailable.pkg/xsysinfo/gpu.go: Enhanced theTotalAvailableVRAMfunction by adding checks to ensure thatgpu,gpu.Node, andgpu.Node.Memoryare not nil before accessing their properties, improving stability when processing GPU information.Notes for Reviewers
Signed commits