[code-infra] Bump eslint to v9 #46222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46222--material-ui.netlify.app/ Bundle size report |
brijeshb42
force-pushed
the
eslint-v9
branch
5 times, most recently
from
f8550fd to
478af7e
Compare
Janpot
approved these changes
May 28, 2025
There was a problem hiding this comment.
Should be good. What's the effect of airbnb/javascript#2961 not being merged?
The only thing that I found is that we can't easily migrate to flat config without copy-pasting/duplicating some code. |
This still uses the same eslint configuration file by setting ESLINT_USE_FLAT_CONFIG to `false` to reduce the scope of the PR, plus we are blocked on [this](airbnb/javascript#2961) to be implemented. Other change is the swapping of `eslint-plugin-filenames` to `eslint-plugin-consistent-default-export-name` since the previous one was creating issue when running the linter.
brijeshb42
pushed a commit
to brijeshb42/mui-x
that referenced
this pull request
May 28, 2025
See the equivalent core PR mui/material-ui#46222 The only extra change done is updating an import to `@mui/utils/useEnhancedEffect` as eslint was complaining.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still uses the same eslint configuration file by setting
ESLINT_USE_FLAT_CONFIGtofalseto reduce the scope of the PR, plus we are blocked on this to be implemented.Other change is the swapping of
eslint-plugin-filenamestoeslint-plugin-consistent-default-export-namesince the previous one was creating issue when running the linter. The new plugin is still old but newer thaneslint-plugin-filenames.This PR doesn't change anything for other repos since they'll still be importing the same
.eslintrc.jsfile.Part of the effort to implement this - mui/mui-public#264