Skip to content

Tracking: Drop support for python 3.8 #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 5 tasks
Tracked by #2064
dangotbanned opened this issue Feb 24, 2025 · 4 comments
Open
1 of 5 tasks
Tracked by #2064

Tracking: Drop support for python 3.8 #2084

dangotbanned opened this issue Feb 24, 2025 · 4 comments
Labels
blocked dependencies Pull requests that update a dependency file

Comments

@dangotbanned
Copy link
Member

dangotbanned commented Feb 24, 2025

Had quite the ordeal trying to avoid the bugs of Protocol in (#2064 (comment)).
If that compatibility code gets merged, I'd really like to remove it ASAP.
It adds a lot of complexity for a version almost 5 months past EOL

Note

Collected more info on Protocol issues in (#2294 (comment))

I collected a lot of info a while back in a similar issue for altair

Downstream "<=3.8"

All projects listed in README.md#used-by have dropped 3.8 support, except:

Upstream

@FBruzzesi
Copy link
Member

As mentioned in Discord, timebasedcv will keep working with the latest Narwhals version that supports python 3.8 (for python 3.8), thus let's not consider that a blocker for dropping support for 3.8.
The library is quite feature complete for now and I am not planning many developments that depends on new narwhals features

@dangotbanned
Copy link
Member Author

dangotbanned commented Feb 25, 2025

#2084 (comment)

Got it, thanks @FBruzzesi - just edited the description

dangotbanned added a commit that referenced this issue Mar 8, 2025
- Bit confused as what I've done is fairly similar to (#2130)
- Getting the same issue as (#2084)

https://github.com/narwhals-dev/narwhals/actions/runs/13740460535/job/38429062404?pr=2149
@dangotbanned
Copy link
Member Author

Might be useful to decide on something like this moving forward

@dangotbanned
Copy link
Member Author

Minimum version bumps

Dropping support for 3.8 will trigger these bumps

Package Minimum Source
pandas 1.1.3 https://pandas.pydata.org/docs/whatsnew/v1.1.3.html#added-support-for-new-python-version
modin 0.8.2 modin-project/modin#2371

narwhals/narwhals/utils.py

Lines 593 to 604 in faebf35

MIN_VERSIONS: dict[Implementation, tuple[int, ...]] = {
Implementation.PANDAS: (0, 25, 3),
Implementation.MODIN: (0, 25, 3),
Implementation.CUDF: (24, 10),
Implementation.PYARROW: (11,),
Implementation.PYSPARK: (3, 5),
Implementation.POLARS: (0, 20, 3),
Implementation.DASK: (2024, 8),
Implementation.DUCKDB: (1,),
Implementation.IBIS: (6,),
Implementation.SQLFRAME: (3, 22, 0),
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants