Code

refactor: Generic CompliantSelector#2064

Code

Merged

dangotbanned merged 69 commits intomainnarwhals-dev/narwhals:mainfrom

more-dedup-1narwhals-dev/narwhals:more-dedup-1Copy head branch name to clipboard

Mar 2, 2025

Commits

Commits on Feb 20, 2025

• refactor: replace `lambda df: df.columns`

  Show description for 028098e
  dangotbanned

  committed
  028098e

  Copy full SHA for 028098e

• refactor: rename `get_columns` -> `get_column_names`

  Show description for c597ba7
  dangotbanned

  committed
  c597ba7

  Copy full SHA for c597ba7

Commits on Feb 21, 2025

• chore(typing): add missing context for `CompliantDataFrame`

  Show description for d26fd81
  dangotbanned

  committed
  d26fd81

  Copy full SHA for d26fd81

• fix(typing): temp widen `.collect` from `CompliantDataFrame`

  Show description for 230daf9
  dangotbanned

  committed
  230daf9

  Copy full SHA for 230daf9

• feat(typing): provide `PandasLikeSeries` to `PandasLikeDataFrame`

  Show description for 2ab3305
  dangotbanned

  committed
  2ab3305

  Copy full SHA for 2ab3305

• feat: Adds generic `CompliantSelector` & `Namespace`

  dangotbanned

  committed
  47816b9

  Copy full SHA for 47816b9

• feat: reimplement `_pandas_like.selectors`

  Show description for c2e56d1
  dangotbanned

  committed
  c2e56d1

  Copy full SHA for c2e56d1

• feat: reimplement `_arrow.selectors`

  Show description for 706732a
  dangotbanned

  committed
  706732a

  Copy full SHA for 706732a

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  7bb8cb2

  Copy full SHA for 7bb8cb2

• refactor: utilize updated `CompliantExpr`

  Show description for 8bf4a49
  dangotbanned

  committed
  8bf4a49

  Copy full SHA for 8bf4a49

• fix(typing): update `_dask` collect as well

  Show description for 1e2e151
  dangotbanned

  committed
  1e2e151

  Copy full SHA for 1e2e151

• fix: maybe resolve `<3.11` protocol bug

  Show description for 5a36c81
  dangotbanned

  committed
  5a36c81

  Copy full SHA for 5a36c81

• ignore coverage on init

  Show description for 5e45350
  dangotbanned

  committed
  5e45350

  Copy full SHA for 5e45350

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  8fe1ce4

  Copy full SHA for 8fe1ce4

• refactor: Also drop `kwargs` in `_to_expr`

  Show description for 42c2f41
  dangotbanned

  committed
  42c2f41

  Copy full SHA for 42c2f41

• add `CompliantLazyFrame.columns`

  dangotbanned

  committed
  4e89a2e

  Copy full SHA for 4e89a2e

• chore(typing): add `Compliant(Lazy|Data)Frame.schema`

  dangotbanned

  committed
  9210a17

  Copy full SHA for 9210a17

• feat: add some default iteration methods

  Show description for 5382778
  dangotbanned

  committed
  5382778

  Copy full SHA for 5382778

• feat: build out lazy-support

  dangotbanned

  committed
  91c86a0

  Copy full SHA for 91c86a0

• feat: reimplement `_dask.selectors`

  Show description for a8c9d13
  dangotbanned

  committed
  a8c9d13

  Copy full SHA for a8c9d13

• refactor: rename `DataFrameT` -> `FrameT`

  dangotbanned

  committed
  d6a2e41

  Copy full SHA for d6a2e41

• feat: reimplement `_duckdb.selectors`

  Show description for f32c348
  dangotbanned

  committed
  f32c348

  Copy full SHA for f32c348

• fix: guard against back-compat `duckdb`

  Show description for d785eb3
  dangotbanned

  committed
  d785eb3

  Copy full SHA for d785eb3

• feat: reimplement `_spark_like.selectors`

  dangotbanned

  committed
  90229c5

  Copy full SHA for 90229c5

• chore: remove duplicate import

  dangotbanned

  committed
  180b9a3

  Copy full SHA for 180b9a3

Commits on Feb 22, 2025

• chore(typing): ignore valid `_dask.selectors` warnings

  Show description for bfed23f
  dangotbanned

  committed
  bfed23f

  Copy full SHA for bfed23f

• refactor: define `CompliantSelector.__repr__`

  Show description for f060f22
  dangotbanned

  committed
  f060f22

  Copy full SHA for f060f22

• refactor(typing): always use concrete class in `_selector() -> ...`

  Show description for 3c5ea87
  dangotbanned

  committed
  3c5ea87

  Copy full SHA for 3c5ea87

• chore: move comments to discussion threads

  dangotbanned

  committed
  b30f020

  Copy full SHA for b30f020

• style: order w/ unimplemented methods first

  dangotbanned

  committed
  eaa5b1c

  Copy full SHA for eaa5b1c

• ignore `DAR201`

  Show description for 92a96cd
  dangotbanned

  committed
  92a96cd

  Copy full SHA for 92a96cd

• degrade the DX to satisfy pre-commit :disappointed:

  dangotbanned

  committed
  29eb2d0

  Copy full SHA for 29eb2d0

• feat: reuse & define `CompliantNamespace.selectors`

  Show description for 547d62a
  dangotbanned

  committed
  547d62a

  Copy full SHA for 547d62a

• refactor: use `self` not `context`

  Show description for e6f2d07
  dangotbanned

  committed
  e6f2d07

  Copy full SHA for e6f2d07

Commits on Feb 23, 2025

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  9325639

  Copy full SHA for 9325639

• refactor: remove `CompliantSeriesWithDType`

  Show description for 13882a5
  dangotbanned

  committed
  13882a5

  Copy full SHA for 13882a5

• fix(typing): resolve some variance issues

  Show description for 7f65b4b
  dangotbanned

  committed
  7f65b4b

  Copy full SHA for 7f65b4b

• fix(typing): resolve more `mypy` errors

  Show description for c11dc95
  dangotbanned

  committed
  c11dc95

  Copy full SHA for c11dc95

• fix(typing): resolve `when()` related issues

  Show description for ef85eda
  dangotbanned

  committed
  ef85eda

  Copy full SHA for ef85eda

• chore(typing): Ignore all `_dask` warnings

  Show description for 0301a4b
  dangotbanned

  committed
  0301a4b

  Copy full SHA for 0301a4b

• Merge branch 'main' into more-dedup-1

  dangotbanned

  authored
  253e2ea

  Copy full SHA for 253e2ea

• Merge branch 'main' into more-dedup-1

  dangotbanned

  authored
  6d19ba0

  Copy full SHA for 6d19ba0

Commits on Feb 24, 2025

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  0d6d2fc

  Copy full SHA for 0d6d2fc

• chore(typing): resolve `mypy` strict errors

  Show description for 7201454
  dangotbanned

  committed
  7201454

  Copy full SHA for 7201454

• fix(DRAFT): try giving a `super(...)` hints for `3.8`

  Show description for a4edcb7
  dangotbanned

  committed
  a4edcb7

  Copy full SHA for a4edcb7

• don't forget `self`

  Show description for cc00fdc
  dangotbanned

  committed
  cc00fdc

  Copy full SHA for cc00fdc

• fix(DRAFT): try removing `CompliantSelectorNamespace.__init__`

  Show description for b650c78
  dangotbanned

  committed
  b650c78

  Copy full SHA for b650c78

• revert (72014548b6f49b864164167c2372fa43778556ad)

  dangotbanned

  committed
  acd8cbf

  Copy full SHA for acd8cbf

• refactor: try reusing `Protocol`'s `Generic

  Show description for 3be58e6
  dangotbanned

  committed
  3be58e6

  Copy full SHA for 3be58e6

• refactor: try the same for `CompliantExpr`

  Show description for d57c877
  dangotbanned

  committed
  d57c877

  Copy full SHA for d57c877

• fix(DRAFT): try removing `Protocol` altogether?

  Show description for b192deb
  dangotbanned

  committed
  b192deb

  Copy full SHA for b192deb

• fix: only replace `Protocol` for `CompliantExpr`

  Show description for 75c5a81
  dangotbanned

  committed
  75c5a81

  Copy full SHA for 75c5a81

• ignore coverage, remove comments

  Show description for 372f1eb
  dangotbanned

  committed
  372f1eb

  Copy full SHA for 372f1eb

Commits on Feb 25, 2025

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  7979909

  Copy full SHA for 7979909

Commits on Feb 26, 2025

• Merge branch 'main' into more-dedup-1

  dangotbanned

  authored
  0242421

  Copy full SHA for 0242421

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  1abc05a

  Copy full SHA for 1abc05a

Commits on Feb 27, 2025

• Merge branch 'main' into more-dedup-1

  dangotbanned

  authored
  819bf3b

  Copy full SHA for 819bf3b

Commits on Mar 1, 2025

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  3da91c4

  Copy full SHA for 3da91c4

• chore(typing): ignore spark issues

  Show description for c26d7ff
  dangotbanned

  committed
  c26d7ff

  Copy full SHA for c26d7ff

• :unamused:

  Show description for b4f6a51
  dangotbanned

  committed
  b4f6a51

  Copy full SHA for b4f6a51

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  cbc1ee1

  Copy full SHA for cbc1ee1

• refactor: Reuse eager-backend `iter_columns`

  Show description for ec5dd0c
  dangotbanned

  committed
  ec5dd0c

  Copy full SHA for ec5dd0c

Commits on Mar 2, 2025

• Merge branch 'main' into more-dedup-1

  dangotbanned

  authored
  d03cc22

  Copy full SHA for d03cc22

• Merge remote-tracking branch 'upstream/main' into more-dedup-1

  dangotbanned

  committed
  fb05225

  Copy full SHA for fb05225

• refactor: define `CompliantLazyFrame._iter_columns`

  Show description for c180c7e
  dangotbanned

  committed
  c180c7e

  Copy full SHA for c180c7e

• docs: move note back into code

  Show description for e85c934
  dangotbanned

  committed
  e85c934

  Copy full SHA for e85c934

• refactor: remove duplicate import

  dangotbanned

  committed
  a43d5e5

  Copy full SHA for a43d5e5

• typo

  Show description for f5765ff
  dangotbanned

  committed
  f5765ff

  Copy full SHA for f5765ff

• docs: add notes on `3.8` compat code

  Show description for cd31cbe
  dangotbanned

  committed
  cd31cbe

  Copy full SHA for cd31cbe