fix: parse timezone-aware datetime strings as UTC consistently across backends #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
parsing-tz-aware
branch
from
bbe16ad to
7f1d06f
Compare
10 tasks
dangotbanned
reviewed
Mar 7, 2025
| if "pandas" in str(constructor) and PANDAS_VERSION < (1,): | ||
| # "Cannot pass a tz argument when parsing strings with timezone information." | ||
| pytest.skip() | ||
| if "pyarrow_table" in str(constructor) and is_windows(): |
There was a problem hiding this comment.
Hate to be the windows guy but ...
Lines 170 to 172 in caaa840
There was a problem hiding this comment.
I think that util needs updating to use "pyarrow_table" actually
My bad 🤦
There was a problem hiding this comment.
Oh it turns out I accidentally had the right thing lol https://github.com/narwhals-dev/narwhals/actions/runs/13730338881/job/38405984916?pr=2166
Double my bad 🤦🤦
needs reverting (fdb2f48)
There was a problem hiding this comment.
@MarcoGorelli fyi I un-resolved this
dangotbanned
reviewed
Mar 7, 2025
tests/utils.py
Outdated
| @@ -169,4 +169,6 @@ def windows_has_tzdata() -> bool: # pragma: no cover | |||
|
|
|||
| def is_pyarrow_windows_no_tzdata(constructor: Constructor, /) -> bool: | |||
There was a problem hiding this comment.
Truly unfortunate name I settled on here 😭
dangotbanned
reviewed
Mar 7, 2025
dangotbanned
reviewed
Mar 7, 2025
|
thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below