Skip to content

Direct get fixes #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Direct get fixes #6911

merged 2 commits into from
May 21, 2025

Conversation

neilalexander
Copy link
Member

@neilalexander neilalexander commented May 21, 2025

Fixes #6077 by ensuring that we can't select a sequence number from the timestamp that falls below the stream first sequence.

Fixes #6032 by ensuring that the memory store doesn't return the first sequence incorrectly when there are no matching messages.

Signed-off-by: Neil Twigg [email protected]

Fixes #6077 by ensuring that we can't select a sequence number from the
timestamp that falls below the stream first sequence.

Signed-off-by: Neil Twigg <[email protected]>
@neilalexander neilalexander requested a review from a team as a code owner May 21, 2025 10:44
Fixes #6032 by ensuring that the memory store doesn't return the first
sequence incorrectly when there are no matching messages.

Signed-off-by: Neil Twigg <[email protected]>
@neilalexander neilalexander changed the title Fix MultiLastFor underflow bug with UpToTime before first sequence Direct get fixes May 21, 2025
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit ed55544 into main May 21, 2025
48 checks passed
@neilalexander neilalexander deleted the neil/directgetuptotime branch May 21, 2025 17:08
neilalexander added a commit that referenced this pull request May 21, 2025
Includes the following:

- #6912
- #6911

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants