Add custom inbox prefix support for JS pull subscribe #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alparslanavci
changed the title
|
Maybe I'm late but why do not use the inbox_prefix defined in the client class when the connection is created as a default? |
|
Yes, because if the user doesn't has permission to subscribe for the default inbox_prefix (_INBOX.>) we will have a "Violation permissions" error when we try to get the consumer info at this line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #276, custom inbox prefix support is added to core NATS features, but not JS. This PR addresses this issue.
This is an important problem since it affects authorization permissions. If the user cannot specify a custom inbox prefix, the user's messages can be received by the non-authorized users who subscribed to the default inbox subject.