Introduce uuid_utils as optional dependency
#674
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff137
added a commit
to didx-xyz/acapy-cloud
that referenced
this pull request
Mar 30, 2025
With `orjson` and `uuid-utils` extras (from nats-io/nats.py#674)
Signed-off-by: ff137 <[email protected]>
…json` Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
…json` Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
ff137
added a commit
to didx-xyz/acapy-cloud
that referenced
this pull request
May 16, 2025
With `orjson` and `uuid-utils` extras (from nats-io/nats.py#674)
ff137
added a commit
to didx-xyz/acapy-cloud
that referenced
this pull request
May 16, 2025
With `orjson` and `uuid-utils` extras (from nats-io/nats.py#674)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661
Because
uuid_utilsis significantly faster than the defaultuuidlibrary - see above-linked issue for more info.Leaving as draft because this depends on #662.
Decided to merge the Travis jobs testing
orjsonfunctionality together withuuid_utils, to avoid unnecessary extra runs.I also believe that both
orjsonanduuid_utilsshould become the new defaults for the library, but it will probably need some shelf-life of being used in production before that call can be made.Edit: now that Travis is removed, there's a todo to add these extras in the github test run