Skip to content

Add tests scenarios for VerifyConnectivity and GetServerInfo #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Mar 4, 2022

There were two scenarios not covered by tests.
The first one is the case some readers are down and others are running.
The second case is when there are not readers available.

@bigmontz bigmontz requested a review from robsdedude March 4, 2022 11:43
@bigmontz
Copy link
Contributor Author

bigmontz commented Mar 4, 2022

Depends on: neo4j/neo4j-javascript-driver#888

Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

bigmontz added 2 commits March 7, 2022 11:21
There where two scenarios not covered by tests.
The first one is the case some readers are down and others are running.
The second case is when there are not readers available.
@bigmontz bigmontz force-pushed the 5.0-more-verify-conn-tests branch from fe1c6ed to 3e5d702 Compare March 7, 2022 10:21
@bigmontz bigmontz merged commit 9cda53d into neo4j-drivers:5.0 Mar 7, 2022
@bigmontz bigmontz deleted the 5.0-more-verify-conn-tests branch March 7, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants