Improve AuthTokenManager
interface and factory method
#1123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
AuthTokenManager
is designed to handle token expiration only. The AuthTokenManager interface only has methods to receive notifications on security errors related to token expiration:AuthTokenManager.onTokenExpired
. The provided implementationneo4j.expirationBasedAuthTokenManager
is built to support only token expiration. However, we also want to cater for password rotation scenarios.Factory Method Changes
Expiration based and bearer tokens
The method
neo4j.expirationBasedAuthTokenManager
was renamed and moved toneo4j.authTokenManagers.bearer
.Password rotation and basic auth
neo4j.authTokenManagers.basic
was added to handle password rotation withAuthTokenManager
.Development checklist
expirationBasedAuthTokenManager
factory name toauthTokenManagers.bearer
authTokenManagers.basic
factorytestkit-backend