Fix flaky tests on TransactionExecutor suite #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TransactionExecutor tests were mocking the global setTimeout and clearTimeout. This mocks were conflicting with other calls to this api in the browser tests. So, the calls to the set/clear were not being the expected in some situations. Replace the global mock for injecting the functions resolve this issue in a less intrusive way.
bigmontz
force-pushed
the
5.13-fix-flacky-on-transaction-executor-tests
branch
from
13f1d3b to
3b3827c
Compare
… the two methods depends on window to be this
thelonelyvulpes
approved these changes
Sep 6, 2023
robsdedude
approved these changes
Sep 7, 2023
packages/neo4j-driver/test/internal/transaction-executor.test.js
Outdated
Show resolved
Hide resolved
packages/neo4j-driver/test/internal/transaction-executor.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: grant lodge <[email protected]> Co-authored-by: Robsdedude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TransactionExecutor tests were mocking the global setTimeout and clearTimeout. This mocks were conflicting with other calls to this api in the browser tests. So, the calls to the set/clear were not being the expected in some situations.
Replace the global mock for injecting the functions resolve this issue in a less intrusive way.