fix neo4jerror name issue #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
reviewed
Jun 22, 2017
src/v1/error.js
Outdated
| @@ -44,6 +44,12 @@ class Neo4jError extends Error { | |||
| super( message ); | |||
| this.message = message; | |||
| this.code = code; | |||
| Object.defineProperty(this, 'name', { | |||
There was a problem hiding this comment.
Why not just this.name = 'Neo4jError'?
There was a problem hiding this comment.
There was some reading on property definition vs assignment and by defining the property we are making it non enumerable.
http://2ality.com/2012/08/property-definition-assignment.html
There was a problem hiding this comment.
Yeah, code sets enumerable: false. All other properties are enumerable. Can we have name similar?
There was a problem hiding this comment.
Sure I will make the change and push it through.
lutovich
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instanceof Neo4jErrorwill return false but you can use the propertynameinstead to determine the error.Fixes 218