Add .retriable to the Neo4jError
#901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property should helps users to implement custom retries logics. Along with the property, the static function `Neo4jError.isRetriable(error)` and the function `isRetriableError(error)` were added for saving boilerplates and avoid the error typechecking to be spread accross the client and driver code base. The internal function `canRetryOn(error)` and the `retry-strategy` file were removed since the logic implemented there was moved to the `error` module replaced by the `isRetriableError(error)` usage.
bigmontz
force-pushed
the
5.0-retriable-errors
branch
from
634a0b1 to
0fc5145
Compare
injectives
reviewed
Mar 17, 2022
injectives
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property should helps users to implement custom retries logics.
Along with the property, the static function
Neo4jError.isRetriable(error)andthe function
isRetriableError(error)were added for saving boilerplates and avoidthe error type checking to be spread across the client and driver code base.
The internal function
canRetryOn(error)and theretry-strategyfile were removedsince the logic implemented there was moved to the
errormodule replaced bythe
isRetriableError(error)usage.