Skip to content

Remove Bookmark in favor or Bookmarks #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented May 14, 2025

  • Remove deprecated class neo4j.Bookmark in favor of neo4j.Bookmarks.
  • Remove deprecated class session.last_bookmark() in favor of last_bookmarks().

@robsdedude robsdedude force-pushed the remove-bookmark-class branch from 158f0e0 to 07f3e5e Compare May 14, 2025 13:23
@robsdedude robsdedude force-pushed the remove-bookmark-class branch from 07f3e5e to 7aa29ed Compare May 14, 2025 14:16
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robsdedude robsdedude enabled auto-merge (squash) May 15, 2025 15:21
@robsdedude robsdedude merged commit 67f073b into neo4j:6.x May 15, 2025
20 checks passed
@robsdedude robsdedude deleted the remove-bookmark-class branch May 15, 2025 16:24
robsdedude added a commit that referenced this pull request May 23, 2025
Deprecate passing raw sting bookmarks as `initial_bookmarks` to
`GraphDatabase.bookmark_manager()`.
Use a `neo4j.Bookmarks` object instead.

Fixup changelog & type hints amending
#1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants