Skip to content

feat add supermicro MBD-X10SRH-CF and CSE-847BE1C-R1K23LPB #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kquinsland
Copy link
Contributor

Chassis comes with images

I can make an argument either way for including SATA/USB ports on the motherboard as module-bay or not.
I omitted them on the X10SRH-CF for now, pending guidance.

@Copilot Copilot AI review requested due to automatic review settings June 15, 2025 18:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds new YAML definitions for a Supermicro 4U chassis and its matching motherboard.

  • Introduces SuperChassis 847BE1C4-R1K23LPB with detailed module-bay layout and basic metadata.
  • Adds Motherboard X10SRH-CF definition including console ports, network interfaces, and module-bays.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
device-types/Supermicro/SuperChassis-847BE1C4-R1K23LPB.yaml New 4U chassis definition
device-types/Supermicro/MBD-X10SRH-CF.yaml New motherboard definition
Comments suppressed due to low confidence (4)

device-types/Supermicro/SuperChassis-847BE1C4-R1K23LPB.yaml:6

  • The part_number is missing the '4' after 'CSE-847BE1C4'; it should match the model and slug. Please update to CSE-847BE1C4-R1K23LPB.
part_number: CSE-847BE1C-R1K23LPB

device-types/Supermicro/SuperChassis-847BE1C4-R1K23LPB.yaml:165

  • Position "1" for SSD 1 duplicates the HDD bay numbering. Consider using "37" (and "38" for SSD 2) to avoid conflicts with existing drive bay positions.
position: "1"

device-types/Supermicro/MBD-X10SRH-CF.yaml:1

  • Add a schema directive (e.g., # yaml-language-server: $schema=../../schema/racktype.json) at the top of the file for consistent YAML validation.
---

device-types/Supermicro/MBD-X10SRH-CF.yaml:48

  • [nitpick] Consider removing or rephrasing the informal comment "i think?" to maintain clarity and professionalism in code comments.
#  DIMM also counts as a module-bay, i think?

All hail the `autofmt` :D
@kquinsland kquinsland force-pushed the add/supermicro-storage branch from 458a585 to a0c67cd Compare June 15, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant