Skip to content

Add support for Elasticsearch 8.16.x #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
jaffinito opened this issue Jan 8, 2025 · 4 comments
Open
3 tasks

Add support for Elasticsearch 8.16.x #2938

jaffinito opened this issue Jan 8, 2025 · 4 comments

Comments

@jaffinito
Copy link
Member

jaffinito commented Jan 8, 2025

Describe the story, please be clear on scope of the story.

The current instrumentation for Elasticsearch only supports up to 8.15.x. In 8.16.x+ of the client, Elastic.Transport was updated to 0.5.2. This version changes the signature of the Request/RequestAsync APIs.

Old API: https://github.com/elastic/elastic-transport-net/blob/0.4.26/src/Elastic.Transport/ITransport.cs
New API: https://github.com/elastic/elastic-transport-net/blob/0.5.2/src/Elastic.Transport/ITransport.cs
(note that the Elastic.Transport version has been updated multiple times since this issue was created, so additional API verification may be required.)

This will require additional work due to the data we were using (http method, path, and request parameters) no longer being directly available as method parameters. I believe the data is still available, but we will need to look for it in other types.

Acceptance Criteria

  • Elasticsearch client 16.x+ is instrumented
  • Integration tests

Dependencies

  • Dependencies on UI
  • Dependencies on Backend
  • Other dependencies ....

Describe Design Consideration/Limitations

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context here.

Estimates

Please provide initial t-shirt size

@workato-integration
Copy link

@workato-integration workato-integration bot changed the title Add support for Elasticsearch 16.x+ Add support for Elasticsearch 8.15. Jan 10, 2025
@tippmar-nr tippmar-nr changed the title Add support for Elasticsearch 8.15. Add support for Elasticsearch 8.16.x Jan 10, 2025
brnhensley added a commit to brnhensley/docs-website that referenced this issue Apr 3, 2025
@randarAtCondoControl
Copy link

Is there a timeline for when this will be resolved? We recently completed a major migration from 7.16 to 8.17.1, which required significant effort and extensive testing. We've been advised by New Relic support to revert to 8.15.x, but that would mean redoing a large amount of work we’ve already completed.

@randarAtCondoControl
Copy link

Is there a timeline for when this will be resolved? We recently completed a major migration from 7.16 to 8.17.1, which required significant effort and extensive testing. We've been advised by New Relic support to revert to 8.15.x, but that would mean redoing a large amount of work we’ve already completed.

@brnhensley
Is there any update on this? We tried to downgrade to 8.15, but there are breaking changes. This would be a large rollback and retest that I would like to avoid.

@chynesNR
Copy link
Member

Hi @randarAtCondoControl -- apologies for the delay, I understand how frustrating this must be. We've looked into adding support for v8.16 but as you've noticed, the library is substantially different now, and will require a non-trivial amount of dev time to get our instrumentation working again. We're hoping to have a solution this quarter, but due to our other commitments I'm afraid I can't offer a specific timeframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants