Skip to content

fix(providers): add state as default check to Okta #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

hakoares
Copy link
Contributor

@hakoares hakoares commented Jan 15, 2024

☕️ Reasoning

Okta requires state to be included, and as the note for providers/okta states: the Okta provider is based on OIDC. So let's have state in the provider config's checks as default.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes #9625

📌 Resources

@hakoares hakoares requested a review from ThangHuuVu as a code owner January 15, 2024 13:04
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 1:08pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2024 1:08pm

@balazsorban44 balazsorban44 changed the title feat(okta): add state as default check fix(providers): add state as default check to Okta Jan 16, 2024
@balazsorban44 balazsorban44 merged commit e45492a into nextauthjs:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Okta missing state parameter
3 participants